stevenschlansker commented on code in PR #20512:
URL: https://github.com/apache/kafka/pull/20512#discussion_r2337342464
##########
streams/src/main/java/org/apache/kafka/streams/internals/metrics/OpenIterators.java:
##########
@@ -48,10 +51,11 @@ public OpenIterators(final TaskId taskId,
public void add(final MeteredIterator iterator) {
openIterators.add(iterator);
+ updateOldestStartTimestamp();
Review Comment:
In practice, I doubt it matters much, which is why I called it a "nano"
optimization. I leave it in your capable hands to decide if it is worth
implementing :)
That said, we actually are having scalability issues regarding creating
iterators at relatively high frequency - see
https://issues.apache.org/jira/browse/KAFKA-19678
One of our data stores is used almost exclusively for range lookups which
use iterators.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
