stevenschlansker commented on code in PR #20512:
URL: https://github.com/apache/kafka/pull/20512#discussion_r2337325325
##########
streams/src/main/java/org/apache/kafka/streams/internals/metrics/OpenIterators.java:
##########
@@ -48,10 +51,11 @@ public OpenIterators(final TaskId taskId,
public void add(final MeteredIterator iterator) {
openIterators.add(iterator);
+ updateOldestStartTimestamp();
Review Comment:
I am only referring to the `add()` flow - which will add 1, then add 2, then
add 3 - and only the first operation may change the oldest iterator.
I agree in the `remove()` case we much check every time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
