m1a2st commented on code in PR #20243:
URL: https://github.com/apache/kafka/pull/20243#discussion_r2239907701
##########
core/src/main/scala/kafka/server/ReplicaManager.scala:
##########
@@ -230,7 +230,9 @@ class ReplicaManager(val config: KafkaConfig,
val directoryEventHandler: DirectoryEventHandler =
DirectoryEventHandler.NOOP,
val defaultActionQueue: ActionQueue = new
DelayedActionQueue
) extends Logging {
- private val metricsGroup = new KafkaMetricsGroup(this.getClass)
+ private val metricsPackage = "kafka.server"
+ private val metricsClassName =
this.getClass.getSimpleName.replaceAll("\\$$", "")
Review Comment:
If metricsClassName needs to be determined dynamically, why doesn't
metricsPackage also need to be retrieved dynamically?
Also, since all subclasses are test-only, is it necessary for each one to
test metricsClassName individually? WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
