Yunyung commented on code in PR #20399:
URL: https://github.com/apache/kafka/pull/20399#discussion_r2318573502
##########
core/src/main/scala/kafka/server/AbstractFetcherManager.scala:
##########
@@ -30,7 +30,9 @@ import scala.jdk.OptionConverters._
abstract class AbstractFetcherManager[T <: AbstractFetcherThread](val name:
String, clientId: String, numFetchers: Int)
extends Logging {
- private val metricsGroup = new KafkaMetricsGroup(this.getClass)
+ private val metricsPackage = "kafka.server"
+ private val metricsClassName = "AbstractFetcherManager"
+ private val metricsGroup = new KafkaMetricsGroup(metricsPackage,
metricsClassName)
Review Comment:
That’s a good point. It would also be good to add some tests to ensure this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
