ijuma commented on code in PR #19881:
URL: https://github.com/apache/kafka/pull/19881#discussion_r2198543449
##########
clients/src/main/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryReporter.java:
##########
@@ -718,8 +717,8 @@ private Optional<Builder<?>>
createPushRequest(ClientTelemetrySubscription local
ByteBuffer compressedPayload;
try {
compressedPayload = ClientTelemetryUtils.compress(payload,
compressionType);
- } catch (IOException e) {
- log.info("Failed to compress telemetry payload for
compression: {}, sending uncompressed data", compressionType);
+ } catch (Throwable e) {
Review Comment:
Catching `Throwable` would catch things like `OutOfMemoryException` and
various other exceptions that indicate the JVM should exit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
