k-raina commented on code in PR #19881:
URL: https://github.com/apache/kafka/pull/19881#discussion_r2198266270
##########
clients/src/main/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryReporter.java:
##########
@@ -718,8 +717,8 @@ private Optional<Builder<?>>
createPushRequest(ClientTelemetrySubscription local
ByteBuffer compressedPayload;
try {
compressedPayload = ClientTelemetryUtils.compress(payload,
compressionType);
- } catch (IOException e) {
- log.info("Failed to compress telemetry payload for
compression: {}, sending uncompressed data", compressionType);
+ } catch (Throwable e) {
Review Comment:
> Could you share the details of your concern with me?
I see [java
docs](https://docs.oracle.com/javase/7/docs/api/java/lang/Error.html)
mentioning "An Error is a subclass of Throwable that indicates serious problems
that a reasonable application should not try to catch"
##########
clients/src/main/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryReporter.java:
##########
@@ -718,8 +717,8 @@ private Optional<Builder<?>>
createPushRequest(ClientTelemetrySubscription local
ByteBuffer compressedPayload;
try {
compressedPayload = ClientTelemetryUtils.compress(payload,
compressionType);
- } catch (IOException e) {
- log.info("Failed to compress telemetry payload for
compression: {}, sending uncompressed data", compressionType);
+ } catch (Throwable e) {
Review Comment:
> Could you share the details of your concern with me?
I see [java
docs](https://docs.oracle.com/javase/7/docs/api/java/lang/Error.html)
mentioning "An Error is a subclass of Throwable that indicates serious problems
that a reasonable application should not try to catch"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
