jsancio commented on code in PR #19668:
URL: https://github.com/apache/kafka/pull/19668#discussion_r2098450806
##########
raft/src/main/java/org/apache/kafka/raft/RequestManager.java:
##########
@@ -173,58 +194,58 @@ public long backoffBeforeAvailableBootstrapServer(long
currentTimeMs) {
return minBackoffMs;
}
- public boolean hasRequestTimedOut(Node node, long timeMs) {
- ConnectionState state = connections.get(node.idString());
+ public boolean hasRequestTimedOut(Node node, long timeMs, ApiKeys
requestKey) {
+ ConnectionState state = connections.get(NodeAndRequestKey.of(node,
requestKey));
if (state == null) {
return false;
}
return state.hasRequestTimedOut(timeMs);
}
- public boolean isReady(Node node, long timeMs) {
- ConnectionState state = connections.get(node.idString());
+ public boolean isReady(Node node, long timeMs, ApiKeys requestKey) {
+ ConnectionState state = connections.get(NodeAndRequestKey.of(node,
requestKey));
if (state == null) {
return true;
}
boolean ready = state.isReady(timeMs);
if (ready) {
- reset(node);
+ reset(node, requestKey);
}
return ready;
}
- public boolean isBackingOff(Node node, long timeMs) {
- ConnectionState state = connections.get(node.idString());
+ public boolean isBackingOff(Node node, long timeMs, ApiKeys requestKey) {
+ ConnectionState state = connections.get(NodeAndRequestKey.of(node,
requestKey));
if (state == null) {
return false;
}
return state.isBackingOff(timeMs);
}
- public long remainingRequestTimeMs(Node node, long timeMs) {
- ConnectionState state = connections.get(node.idString());
+ public long remainingRequestTimeMs(Node node, long timeMs, ApiKeys
requestKey) {
+ ConnectionState state = connections.get(NodeAndRequestKey.of(node,
requestKey));
if (state == null) {
return 0;
}
return state.remainingRequestTimeMs(timeMs);
}
- public long remainingBackoffMs(Node node, long timeMs) {
- ConnectionState state = connections.get(node.idString());
+ public long remainingBackoffMs(Node node, long timeMs, ApiKeys requestKey)
{
+ ConnectionState state = connections.get(NodeAndRequestKey.of(node,
requestKey));
if (state == null) {
return 0;
}
return state.remainingBackoffMs(timeMs);
}
- public boolean isResponseExpected(Node node, long correlationId) {
- ConnectionState state = connections.get(node.idString());
+ public boolean isResponseExpected(Node node, long correlationId, ApiKeys
requestKey) {
Review Comment:
Let's add Java docs for all of these public methods: `isResponseExpected`,
`remainingBackoffMs`, `remainingRequestTimeMs`, `isBackingOff`, `isReady` and
`hasRequestTimedOut`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
