kevin-wu24 commented on code in PR #19668:
URL: https://github.com/apache/kafka/pull/19668#discussion_r2085111709
##########
raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java:
##########
@@ -2771,16 +2776,17 @@ private RequestSendResult maybeSendRequest(
Supplier<ApiMessage> requestSupplier
) {
var requestSent = false;
+ final var request = requestSupplier.get();
+ final var api = ApiKeys.forId(request.apiKey());
Review Comment:
Yes, I can change that back. I noticed this would change during coding, but
was not sure about the impact. I think the main concern is performance right
(i.e. we're invoking callbacks to read state to generate the api message but
not actually sending it, so it's wasted)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
