jolshan commented on code in PR #19355:
URL: https://github.com/apache/kafka/pull/19355#discussion_r2067459157
##########
clients/src/main/resources/common/message/ListTransactionsRequest.json:
##########
@@ -30,6 +32,9 @@
},
{ "name": "DurationFilter", "type": "int64", "versions": "1+", "default":
-1,
"about": "Duration (in millis) to filter by: if < 0, all transactions
will be returned; otherwise, only transactions running longer than this
duration will be returned."
+ },
+ { "name": "TransactionalIdPattern", "type": "string", "versions": "2+",
"nullableVersions": "2+", "default": "null",
Review Comment:
Any reason why we can't just accept null on the client side? We convert to
"" now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
