CalvinConfluent commented on code in PR #19355:
URL: https://github.com/apache/kafka/pull/19355#discussion_r2067455423
##########
clients/src/main/resources/common/message/ListTransactionsRequest.json:
##########
@@ -30,6 +32,9 @@
},
{ "name": "DurationFilter", "type": "int64", "versions": "1+", "default":
-1,
"about": "Duration (in millis) to filter by: if < 0, all transactions
will be returned; otherwise, only transactions running longer than this
duration will be returned."
+ },
+ { "name": "TransactionalIdPattern", "type": "string", "versions": "2+",
"nullableVersions": "2+", "default": "null",
Review Comment:
Yeah, I think it is because the other regex fields allow null. So we want to
get they aligned, like `SubscribedTopicRegex` in ConsumerGroupHeartbeatRequest.
As for converting to an empty string, I find it is convenient to handle in code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
