jolshan commented on code in PR #19250:
URL: https://github.com/apache/kafka/pull/19250#discussion_r2006621799
##########
clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java:
##########
@@ -234,9 +229,10 @@
* successful writes are marked as aborted, hence keeping the transactional
guarantees.
* </p>
* <p>
- * This client can communicate with brokers that are version 0.10.0 or newer.
Older or newer brokers may not support
- * certain client features. For instance, the transactional APIs need broker
versions 0.11.0 or later. You will receive an
- * <code>UnsupportedVersionException</code> when invoking an API that is not
available in the running broker version.
+ * This client can communicate with brokers that are version 2.1 or newer.
Older brokers may not support
+ * certain client features. For instance, {@code sendOffsetsToTransaction}
with all consumer group metadata needs broker
+ * versions 2.5 or later. You will receive an
<code>UnsupportedVersionException</code> when invoking an API that is not
Review Comment:
I was a little confused by this at first, so I did some digging.
This message is due to the change in the signature of
`sendOffsetsToTransaction` requiring `ConsumerGroupMetadata groupMetadata`
rather than `String consumerGroupId` (KIP introducing the concept
[here](https://cwiki.apache.org/confluence/display/KAFKA/KIP-447%3A+Producer+scalability+for+exactly+once+semantics),
and old method signature deprecated in
[this](https://github.com/apache/kafka/commit/3805f3706f8f3ebba81b80915c9259590525fb05)
commit)
But yes, this is correct. 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
