chia7712 commented on code in PR #19250:
URL: https://github.com/apache/kafka/pull/19250#discussion_r2016352250
##########
clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java:
##########
@@ -61,9 +61,9 @@
* The consumer is not thread-safe. See <a
href="#multithreaded">Multi-threaded Processing</a> for more details.
*
* <h3>Cross-Version Compatibility</h3>
- * This client can communicate with brokers that are version 0.10.0 or newer.
Older or newer brokers may not support
- * certain features. For example, 0.10.0 brokers do not support
offsetsForTimes, because this feature was added
- * in version 0.10.1. You will receive an {@link
org.apache.kafka.common.errors.UnsupportedVersionException}
+ * This client can communicate with brokers that are version 2.1 or newer.
Older or newer brokers may not support
+ * certain features. For example, 3.9 brokers do not support {@code
subscribe(SubscriptionPattern)}, because this feature was added
Review Comment:
Maybe we can use `link` instead of `code`?
```
{@link KafkaConsumer#subscribe(SubscriptionPattern)}
```
##########
clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java:
##########
@@ -61,9 +61,9 @@
* The consumer is not thread-safe. See <a
href="#multithreaded">Multi-threaded Processing</a> for more details.
*
* <h3>Cross-Version Compatibility</h3>
- * This client can communicate with brokers that are version 0.10.0 or newer.
Older or newer brokers may not support
- * certain features. For example, 0.10.0 brokers do not support
offsetsForTimes, because this feature was added
- * in version 0.10.1. You will receive an {@link
org.apache.kafka.common.errors.UnsupportedVersionException}
+ * This client can communicate with brokers that are version 2.1 or newer.
Older brokers may not support
+ * certain features. For example, 3.9 brokers do not support {@code
subscribe(SubscriptionPattern)}, because this feature was added
+ * in version 4.0. You will receive an {@link
org.apache.kafka.common.errors.UnsupportedVersionException}
Review Comment:
Should we highlight that this feature is supported exclusively by the async
consumer? Or we can write that Classic consumer does not support it and Classic
consumer throws `java.lang.UnsupportedOperationException` directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
