chia7712 commented on code in PR #19207:
URL: https://github.com/apache/kafka/pull/19207#discussion_r2008606882
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java:
##########
@@ -937,19 +934,14 @@ public List<CoordinatorRecord> onPartitionsDeleted(
* @param topic The topic name.
* @param partition The partition.
* @param records The list of records to append the tombstone.
- *
- * @return The topic partition of the corresponding tombstone.
*/
- private TopicPartition appendOffsetCommitTombstone(
+ private void appendOffsetCommitTombstone(
String groupId,
String topic,
int partition,
List<CoordinatorRecord> records
) {
records.add(GroupCoordinatorRecordHelpers.newOffsetCommitTombstoneRecord(groupId,
topic, partition));
- TopicPartition tp = new TopicPartition(topic, partition);
- log.trace("[GroupId {}] Removing expired offset and metadata for {}",
groupId, tp);
Review Comment:
we should keep this log, but it can be rewrite without `TopicPartition`. for
example:
```java
log.trace("[GroupId {}] Removing expired offset and metadata for {}-{}",
groupId, topic, partition);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
