Rancho-7 commented on code in PR #19207:
URL: https://github.com/apache/kafka/pull/19207#discussion_r2001068677
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java:
##########
@@ -875,7 +872,7 @@ public boolean cleanupExpiredOffsets(String groupId,
List<CoordinatorRecord> rec
// We don't expire the offset yet if there is a pending
transactional offset for the partition.
if (condition.isOffsetExpired(offsetAndMetadata,
currentTimestampMs, config.offsetsRetentionMs()) &&
!hasPendingTransactionalOffsets(groupId, topic,
partition)) {
-
expiredPartitions.add(appendOffsetCommitTombstone(groupId, topic, partition,
records).toString());
+ appendOffsetCommitTombstone(groupId, topic, partition,
records);
Review Comment:
Since we no longer use `expiredPartitions ` to track the return values,I
believe it might be unnessary to retain it.Please let me know if I made a
mistake.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
