mjsax commented on code in PR #18778:
URL: https://github.com/apache/kafka/pull/18778#discussion_r1940558829
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopologyBuilder.java:
##########
@@ -507,46 +510,23 @@ public final <K, V> void addSink(final String name,
final Serializer<V> valSerializer,
final StreamPartitioner<? super K, ?
super V> partitioner,
final String... predecessorNames) {
- Objects.requireNonNull(name, "name must not be null");
- Objects.requireNonNull(topic, "topic must not be null");
- Objects.requireNonNull(predecessorNames, "predecessor names must not
be null");
Review Comment:
Move this and some other checks into another helper `verifyParents`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
