mjsax commented on code in PR #18778:
URL: https://github.com/apache/kafka/pull/18778#discussion_r1940553477
##########
streams/src/main/java/org/apache/kafka/streams/Topology.java:
##########
@@ -677,10 +662,10 @@ public synchronized <KIn, VIn, KOut, VOut> Topology
addProcessor(final String na
*
* @throws TopologyException
* if the {@link StoreBuilder#name() state store} was already
added, or
- * if a processor name is unknown
+ * if a processor name is unknown or specifies a source or sink
Review Comment:
I did find the check for "sinks as parent nodes" when processors and sink
are added. Realized that adding stores to sources/sinks does not make sense
either -- added new checks in internal classed for it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
