apoorvmittal10 commented on code in PR #16888:
URL: https://github.com/apache/kafka/pull/16888#discussion_r1899417610
##########
build.gradle:
##########
@@ -901,6 +901,44 @@ project(':server') {
}
}
+project(':share') {
+ base {
+ archivesName = "kafka-share"
Review Comment:
@ijuma Thanks for the feedback.
> That said, do we expect this module to have a reasonable set of classes?
Though initally I was of an opinion to have code in `server` module itself
but then I agree with @mumrah that it might be sensible to keep in separate
module as the code is growing for share groups.
> I think this name is too generic, perhaps kafka-share-common
Sure, do you think `share-group` would be a better name? As module currently
holds code related to `share-fetch` and `share-persister`, which are part of
overall `share-groups` to function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
