ijuma commented on code in PR #16888:
URL: https://github.com/apache/kafka/pull/16888#discussion_r1896071288
##########
build.gradle:
##########
@@ -901,6 +901,44 @@ project(':server') {
}
}
+project(':share') {
+ base {
+ archivesName = "kafka-share"
Review Comment:
I think this name is too generic, perhaps `kafka-share-common` would be more
aligned with the existing project convention.
That said, do we expect this module to have a reasonable set of classes? If
not, a dedicated module may not be worth it.
When it comes to modules, it's important to strike a balance. Too many
modules make the system harder to maintain and understand. And they also get
exposed to users since these end up as separate jars, Maven modules, etc.
Similarly, the opposite results in bad compilation and test time, etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
