Goooler commented on code in PR #18018:
URL: https://github.com/apache/kafka/pull/18018#discussion_r1897024859
##########
build.gradle:
##########
@@ -353,17 +353,14 @@ subprojects {
if (!shouldPublishWithShadow) {
from components.java
} else {
- apply plugin: 'io.github.goooler.shadow'
- project.shadow.component(mavenJava)
+ apply plugin: 'com.gradleup.shadow'
+ from components.shadow
// Fix for avoiding inclusion of runtime dependencies marked as
'shadow' in MANIFEST Class-Path.
- // https://github.com/johnrengelman/shadow/issues/324
+ // https://github.com/GradleUp/shadow/issues/324
afterEvaluate {
pom.withXml { xml ->
- if (xml.asNode().get('dependencies') == null) {
- xml.asNode().appendNode('dependencies')
- }
- def dependenciesNode = xml.asNode().get('dependencies').get(0)
+ def dependenciesNode = xml.asNode().get('dependencies') ?:
xml.asNode().appendNode('dependencies')
Review Comment:
The real change is here, picked it from
https://github.com/GradleUp/shadow/blob/19ed88908a8390d6ca9ada50f4067f653bbae6b6/src/main/groovy/com/github/jengelman/gradle/plugins/shadow/ShadowExtension.groovy#L39-L50.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
