dejan2609 commented on PR #18018:
URL: https://github.com/apache/kafka/pull/18018#issuecomment-2561291264
Kudos for @Goooler for jumping in and saving a day :medal_sports: :+1:
It seems that PR is good to go now, herewith some comparison (trunk vs. this
PR):
1. **pom.xml files are equivalent (PR version just adds some comments):**
```
dejan@dejan-HP-ProBook-450-G7:~$ diff
~/.m2/repository/org/apache/kafka-8.3.5/kafka-clients/4.1.0-SNAPSHOT/kafka-clients-4.1.0-SNAPSHOT.pom
~/.m2/repository/org/apache/kafka-trunk/kafka-clients/4.1.0-SNAPSHOT/kafka-clients-4.1.0-SNAPSHOT.pom
3,7d2
< <!-- This module was also published with a richer model, Gradle
metadata, -->
< <!-- which should be used instead. Do not delete the following line
which -->
< <!-- is to indicate to Gradle or any Gradle module metadata file
consumer -->
< <!-- that they should prefer consuming it instead. -->
< <!-- do_not_remove: published-with-gradle-metadata -->
dejan@dejan-HP-ProBook-450-G7:~$
```
2. **MANIFEST.MF files are identical:**
```
dejan@dejan-HP-ProBook-450-G7:~$ diff
~/.m2/repository/org/apache/kafka-trunk/kafka-clients/4.1.0-SNAPSHOT/kafka-clients-4.1.0-SNAPSHOT.jar.folder/META-INF/MANIFEST.MF
~/.m2/repository/org/apache/kafka-8.3.5/kafka-clients/4.1.0-SNAPSHOT/kafka-clients-4.1.0-SNAPSHOT.jar.folder/META-INF/MANIFEST.MF
dejan@dejan-HP-ProBook-450-G7:~$ date
Tue 24 Dec 17:32:48 CET 2024
```
3. **there is a one difference when it comes to publications; I assume this
is an expected behavior (and by the looks of it it won't hurt in any way):**
- _trunk publications:_
```
-rw-rw-r-- 1 dejan dejan 9.2M Dec 24 16:57 kafka-clients-4.1.0-SNAPSHOT.jar
-rw-rw-r-- 1 dejan dejan 2.2M Dec 24 16:57
kafka-clients-4.1.0-SNAPSHOT-javadoc.jar
-rw-rw-r-- 1 dejan dejan 1.4K Dec 24 16:57 kafka-clients-4.1.0-SNAPSHOT.pom
-rw-rw-r-- 1 dejan dejan 3.7M Dec 24 16:57
kafka-clients-4.1.0-SNAPSHOT-sources.jar
-rw-rw-r-- 1 dejan dejan 2.6M Dec 24 16:57
kafka-clients-4.1.0-SNAPSHOT-test.jar
-rw-rw-r-- 1 dejan dejan 1.3M Dec 24 16:57
kafka-clients-4.1.0-SNAPSHOT-test-sources.jar
-rw-rw-r-- 1 dejan dejan 1.6K Dec 24 16:57 maven-metadata-local.xml
```
- _this PR is publishing one additional file
(kafka-clients-4.1.0-SNAPSHOT.module):_
```
-rw-rw-r-- 1 dejan dejan 9.2M Dec 24 17:05 kafka-clients-4.1.0-SNAPSHOT.jar
-rw-rw-r-- 1 dejan dejan 2.2M Dec 24 17:05
kafka-clients-4.1.0-SNAPSHOT-javadoc.jar
-rw-rw-r-- 1 dejan dejan 1.1K Dec 24 17:05
kafka-clients-4.1.0-SNAPSHOT.module
-rw-rw-r-- 1 dejan dejan 1.8K Dec 24 17:05 kafka-clients-4.1.0-SNAPSHOT.pom
-rw-rw-r-- 1 dejan dejan 3.7M Dec 24 17:05
kafka-clients-4.1.0-SNAPSHOT-sources.jar
-rw-rw-r-- 1 dejan dejan 2.6M Dec 24 17:05
kafka-clients-4.1.0-SNAPSHOT-test.jar
-rw-rw-r-- 1 dejan dejan 1.3M Dec 24 17:05
kafka-clients-4.1.0-SNAPSHOT-test-sources.jar
```
- _kafka-clients-4.1.0-SNAPSHOT.module content:_
```
dejan@dejan-HP-ProBook-450-G7:~/.m2/repository/org/apache/kafka-8.3.5/kafka-clients/4.1.0-SNAPSHOT$
cat kafka-clients-4.1.0-SNAPSHOT.module
{
"formatVersion": "1.1",
"component": {
"group": "org.apache.kafka",
"module": "kafka-clients",
"version": "4.1.0-SNAPSHOT",
"attributes": {
"org.gradle.status": "integration"
}
},
"createdBy": {
"gradle": {
"version": "8.10.2"
}
},
"variants": [
{
"name": "shadowRuntimeElements",
"attributes": {
"org.gradle.category": "library",
"org.gradle.dependency.bundling": "shadowed",
"org.gradle.libraryelements": "jar",
"org.gradle.usage": "java-runtime"
},
"files": [
{
"name": "kafka-clients-4.1.0-SNAPSHOT.jar",
"url": "kafka-clients-4.1.0-SNAPSHOT.jar",
"size": 9607290,
"sha512":
"1b2165fe9a93bbc437f61b4144c406e2677d33a62ce1c20be75bf90fca4ca1364e597365301bd6a0cf74fa58fe454bf09a0cef81727fb2d3a253926968874a15",
"sha256":
"d76560f10d577b554c1aca1a98bfc72144c8fafd90cb787e6c0bb819af254918",
"sha1": "20efda5807de75530682f567ef8622cd23ca283f",
"md5": "0661f254d99c92749d06c464170cfc16"
}
]
}
]
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
