nicktelford commented on code in PR #16922:
URL: https://github.com/apache/kafka/pull/16922#discussion_r1818829070
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorStateManager.java:
##########
@@ -314,7 +348,7 @@ void initializeStoreOffsetsFromCheckpoint(final boolean
storeDirIsEmpty) {
}
private void maybeRegisterStoreWithChangelogReader(final String storeName)
{
- if (isLoggingEnabled(storeName)) {
+ if (isLoggingEnabled(storeName) && changelogReader != null) {
Review Comment:
WRT refactoring ProcessorStateManager: that might be a good idea in the
longer term, although I'd like to avoid doing it here, to limit the size and
scope of this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
