ableegoldman commented on code in PR #16922:
URL: https://github.com/apache/kafka/pull/16922#discussion_r1788523793
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorStateManager.java:
##########
@@ -222,6 +223,39 @@ public ProcessorStateManager(final TaskId taskId,
log.debug("Created state store manager for task {}", taskId);
}
+ /**
+ * Special constructor used by {@link StateDirectory} to partially
initialize "pending" tasks for local state, before
Review Comment:
nit: can we make it a bit more obvious that this is a "special constructor"
by having a static constructor method called
#createUninitializedTaskStateManager or #createUnassignedTaskStateManager
(something to that effect) -- I just always worry about leaving essential
context in comments/javadocs since they so easily end up out-of-date and
incorrect
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
