smjn commented on code in PR #17270:
URL: https://github.com/apache/kafka/pull/17270#discussion_r1790811828
##########
core/src/main/scala/kafka/server/BrokerServer.scala:
##########
@@ -764,9 +783,16 @@ class BrokerServer(
if (socketServer != null)
CoreUtils.swallow(socketServer.shutdown(), this)
+
Utils.closeQuietly(brokerTopicStats, "broker topic stats")
Utils.closeQuietly(sharePartitionManager, "share partition manager")
+ if (persister != null)
+ CoreUtils.swallow(persister.stop(), this)
Review Comment:
Will remove this from SharePartitionManager - it should not be closing the
persister as it is an external dep. BrokerServer will be responsible for the
lifecycle.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
