smjn commented on code in PR #17270:
URL: https://github.com/apache/kafka/pull/17270#discussion_r1792209784
##########
core/src/main/scala/kafka/server/BrokerServer.scala:
##########
@@ -345,7 +347,29 @@ class BrokerServer(
tokenManager = new DelegationTokenManager(config, tokenCache, time)
tokenManager.startup()
- shareCoordinator = createShareCoordinator()
+ /* get persister instance */
+ persister = if
(config.shareGroupConfig.shareGroupPersisterClassName.nonEmpty) {
+ val klass =
Utils.loadClass(config.shareGroupConfig.shareGroupPersisterClassName,
classOf[Object]).asInstanceOf[Class[Persister]]
+ klass.getDeclaredMethod("getInstance")
Review Comment:
After some discussion we have concluded that the persister will be Factory
pluggable. That is will an internal config which will not be exposed to the
user.
The implementations will be internal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
