LoganZhuZzz commented on PR #17280:
URL: https://github.com/apache/kafka/pull/17280#issuecomment-2380569589
> Thanks @LoganZhuZzz, the script output looks good. Can you try the
following for me:
>
> 1. Add a `ignoreRatFailure` parameter to build.gradle that controls `rat {
failOnError }`
> 2. Pass in this param in build.yml when we invoke `check -x test`
> 3. Modify rat.py to exit 1 if it finds any problems
>
> This way, the link to the failed workflow will take us to the Rat output
rather than the first failing step.
>
> Also, could you include "::notice" output in the script similar to this
https://github.com/apache/kafka/blob/trunk/.github/scripts/checkstyle.py#L64?
This is how we actually create the annotations. Note that the line number
starts with 1.
https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/workflow-commands-for-github-actions#setting-a-notice-message
Thanks for the guidance. @mumrah
I have fixed the above issues, If you notice any areas for improvement or
any bad practices, please let me know.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
