mumrah commented on code in PR #17280:
URL: https://github.com/apache/kafka/pull/17280#discussion_r1776934010


##########
.github/workflows/build.yml:
##########
@@ -68,6 +68,11 @@ jobs:
           ./gradlew --build-cache --info  \
           ${{ inputs.is-public-fork && '--no-scan' || '--scan' }} \
           check -x test
+      - name: Annotate Rat errors

Review Comment:
   Can you move this down with the checkstyle step?



##########
.github/workflows/build.yml:
##########
@@ -68,6 +68,11 @@ jobs:
           ./gradlew --build-cache --info  \
           ${{ inputs.is-public-fork && '--no-scan' || '--scan' }} \
           check -x test
+      - name: Annotate Rat errors
+        if: ${{ failure() }}

Review Comment:
   We should only run this on java 21 to avoid duplicate reports from the 
parallel builds



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to