mumrah commented on code in PR #17149:
URL: https://github.com/apache/kafka/pull/17149#discussion_r1776956765
##########
share-coordinator/src/test/java/org/apache/kafka/coordinator/share/StateBatchUtilTest.java:
##########
@@ -60,36 +60,60 @@ static class BatchTestHolder {
this.shouldRun = shouldRun;
}
+ static List<PersisterStateBatch> singleBatch(
+ long firstOffset,
+ long lastOffset,
+ byte deliveryState,
+ short deliveryCount
Review Comment:
I would let these be `int` so we can avoid casting in the test code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
