aliehsaeedii commented on code in PR #17091:
URL: https://github.com/apache/kafka/pull/17091#discussion_r1772854023
##########
clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerRecords.java:
##########
@@ -35,11 +35,18 @@ public class ConsumerRecords<K, V> implements
Iterable<ConsumerRecord<K, V>> {
public static final ConsumerRecords<Object, Object> EMPTY = new
ConsumerRecords<>(Collections.emptyMap());
private final Map<TopicPartition, List<ConsumerRecord<K, V>>> records;
+ private Map<TopicPartition, OffsetAndMetadata> nextOffsets;
public ConsumerRecords(Map<TopicPartition, List<ConsumerRecord<K, V>>>
records) {
Review Comment:
I agree with initializing the `nextOffsets` with an empty map in the current
constructor but changing the current constructor input parameters may break the
users code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
