lucasbru commented on code in PR #17091:
URL: https://github.com/apache/kafka/pull/17091#discussion_r1771058136


##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java:
##########
@@ -1820,6 +1820,9 @@ void addRecordsToTasks(final ConsumerRecords<byte[], 
byte[]> records) {
             }
 
             activeTask.addRecords(partition, records.records(partition));
+
+            if (activeTask instanceof StreamTask)

Review Comment:
   It may be nice to get rid of this `instanceof` check, e.g. by extending the 
signature of `addRecords` with a map for `nextOffsets`. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to