mimaison commented on code in PR #17042:
URL: https://github.com/apache/kafka/pull/17042#discussion_r1760013286
##########
core/src/main/scala/kafka/log/UnifiedLog.scala:
##########
@@ -906,7 +907,7 @@ class UnifiedLog(@volatile var logStartOffset: Long,
updateHighWatermarkWithLogEndOffset()
// update the producer state
- updatedProducers.values.foreach(producerAppendInfo =>
producerStateManager.update(producerAppendInfo))
+ updatedProducers.values.asScala.foreach(producerAppendInfo =>
producerStateManager.update(producerAppendInfo))
Review Comment:
Right we don't need this conversion.
##########
core/src/main/scala/kafka/log/UnifiedLog.scala:
##########
@@ -1775,7 +1776,7 @@ class UnifiedLog(@volatile var logStartOffset: Long,
producerExpireCheck.cancel(true)
leaderEpochCache.foreach(_.clear())
val deletedSegments = localLog.deleteAllSegments()
Review Comment:
Good point!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
