mimaison commented on code in PR #17042:
URL: https://github.com/apache/kafka/pull/17042#discussion_r1760004163
##########
core/src/main/scala/kafka/log/UnifiedLog.scala:
##########
@@ -1952,19 +1953,17 @@ class UnifiedLog(@volatile var logStartOffset: Long,
private[log] def addSegment(segment: LogSegment): LogSegment =
localLog.segments.add(segment)
private def maybeHandleIOException[T](msg: => String)(fun: => T): T = {
- LocalLog.maybeHandleIOException(logDirFailureChannel, parentDir, msg) {
- fun
- }
+ JLocalLog.maybeHandleIOException(logDirFailureChannel, parentDir, () =>
msg, () => fun)
}
private[log] def splitOverflowedSegment(segment: LogSegment):
List[LogSegment] = lock synchronized {
val result = UnifiedLog.splitOverflowedSegment(segment, localLog.segments,
dir, topicPartition, config, scheduler, logDirFailureChannel, logIdent)
deleteProducerSnapshots(result.deletedSegments, asyncDelete = true)
- result.newSegments.toList
+ result.newSegments.asScala.toList
Review Comment:
The return value is used in a few places in `LogLoaderTest`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
