cmccabe commented on PR #17192: URL: https://github.com/apache/kafka/pull/17192#issuecomment-2349940193
I changed the PR slightly to simply forbid setting `broker.id` to -1, rather than forbidding `broker.id.generation.enable = true`. Although the latter approach is more conceptually pure, it would be more disruptive in practice. If someone has a cluster where all their broker IDs are defined, and is not using auto generation, they should not get an error even if they happen to have `broker.id.generation.enable = true`. (One thing to note is a lot of our tests set `broker.id.generation.enable = true`, although almost none of them actually use it!) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
