cmccabe commented on code in PR #17192:
URL: https://github.com/apache/kafka/pull/17192#discussion_r1759342568
##########
core/src/main/scala/kafka/server/KafkaServer.scala:
##########
@@ -1135,6 +1132,10 @@ class KafkaServer(
* @return The brokerId.
*/
private def getOrGenerateBrokerId(metaPropsEnsemble:
MetaPropertiesEnsemble): Int = {
+ if (config.migrationEnabled && config.brokerIdGenerationEnable) {
Review Comment:
The existing docs should be OK here, now that I have altered the PR to
forbid broker id being set to -1, rather than forbidding
`broker.id.generation.enable`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
