AndrewJSchofield commented on code in PR #17070: URL: https://github.com/apache/kafka/pull/17070#discussion_r1755699255
########## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/DynamicGroupConfig.java: ########## @@ -0,0 +1,88 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.coordinator.group; + +import org.apache.kafka.common.config.ConfigDef; +import org.apache.kafka.common.errors.InvalidConfigurationException; +import org.apache.kafka.common.utils.Utils; +import org.apache.kafka.server.share.ShareGroupConfig; +import org.apache.kafka.server.share.ShareGroupDynamicConfig; + +import java.util.Arrays; +import java.util.Optional; +import java.util.Properties; + +public class DynamicGroupConfig { Review Comment: I see what you've done with merging the configs here, but I think it would be nicer if it was just called `GroupConfig`. Then we need to be able to have a class for the type-specific group configurations which are currently consumer groups, share groups, and soon to be streams groups. Ideally, we would not have inter-component relationships which differ by group type. ########## coordinator-common/src/main/java/org/apache/kafka/coordinator/common/runtime/GroupType.java: ########## @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.coordinator.common.runtime; + +import java.util.Arrays; +import java.util.Locale; +import java.util.Map; +import java.util.function.Function; +import java.util.stream.Collectors; + +public enum GroupType { Review Comment: I don't understand the need to create this new class. There is already `o.a.k.common.GroupType` and also `o.a.k.coordinator.group.Group.GroupType`. These are essentially all the same. What's to stop us using `o.a.k.common.GroupType` in the server? ########## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/ConsumerGroupDynamicConfig.java: ########## @@ -32,10 +31,10 @@ import static org.apache.kafka.common.config.ConfigDef.Type.INT; /** - * Group configuration related parameters and supporting methods like validation, etc. are + * Consumer Group Dynamic configuration related parameters and supporting methods like validation, etc. are * defined in this class. */ -public class GroupConfig extends AbstractConfig { +public class ConsumerGroupDynamicConfig extends AbstractConfig { Review Comment: I don't quite see the need for `Dynamic` in the class name here. `ConsumerGroupConfig` is fine, and then `ShareGroupConfig`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
