smjn commented on code in PR #17070:
URL: https://github.com/apache/kafka/pull/17070#discussion_r1741067432
##########
core/src/test/java/kafka/server/share/SharePartitionManagerTest.java:
##########
@@ -1068,10 +1070,10 @@ public void testProcessFetchResponse() {
Map<SharePartitionManager.SharePartitionKey, SharePartition>
partitionCacheMap = new ConcurrentHashMap<>();
partitionCacheMap.computeIfAbsent(new
SharePartitionManager.SharePartitionKey(groupId, tp0),
k -> new SharePartition(groupId, tp0, MAX_IN_FLIGHT_MESSAGES,
MAX_DELIVERY_COUNT,
- RECORD_LOCK_DURATION_MS, mockTimer, new MockTime(),
NoOpShareStatePersister.getInstance()));
+ mockTimer, new MockTime(),
NoOpShareStatePersister.getInstance(), DEFAULT_RECORD_LOCK_DURATION_MS,
GROUP_CONFIG_MANAGER));
Review Comment:
indentation issue
might want to set correct value in idea
settings > editor > code style > java > set tab/indent/continuation ident to
5
There are some more occurrences below
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorConfig.java:
##########
@@ -162,6 +162,18 @@ public class GroupCoordinatorConfig {
public static final int SHARE_GROUP_MAX_HEARTBEAT_INTERVAL_MS_DEFAULT =
15000;
public static final String SHARE_GROUP_MAX_HEARTBEAT_INTERVAL_MS_DOC =
"The maximum heartbeat interval for share group members.";
+ public static final String SHARE_GROUP_RECORD_LOCK_DURATION_MS_CONFIG =
"group.share.record.lock.duration.ms";
Review Comment:
we have separate ShareCoordinatorConfig and ShareGroupConfig files
can this be moved to one of them?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
