chia7712 commented on code in PR #17046:
URL: https://github.com/apache/kafka/pull/17046#discussion_r1755095302
##########
core/src/test/java/kafka/admin/ConfigCommandIntegrationTest.java:
##########
@@ -325,6 +358,35 @@ private void verifyGroupConfigUpdate() throws Exception {
}
}
+
+ @ClusterTest(types = {Type.KRAFT})
+ public void testClientMetricsConfigUpdate() throws Exception {
+ alterOpts = asList("--bootstrap-server", cluster.bootstrapServers(),
"--entity-type", "client-metrics", "--alter");
+ verifyClientMetricsConfigUpdate();
+
+ // Test for the --client-metrics alias
+ alterOpts = asList("--bootstrap-server", cluster.bootstrapServers(),
"--client-metrics", "--alter");
Review Comment:
the arguments generated by this test case is `--client-metrics --alter
--entity-name cm --add-config interval.ms=6000,metrics=`, but that is illegal
actually since the "--alter" is viewed as entity name. It can work since we
don't call check and `ConfigCommand#alterConfig` process only first entity.
Luckily, "cm" is the first entity
Maybe we can handle this in follow-up as it needs minor refactor. the tests
of other resource types have similar issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
