AndrewJSchofield commented on code in PR #17046:
URL: https://github.com/apache/kafka/pull/17046#discussion_r1754598635
##########
core/src/test/java/kafka/admin/ConfigCommandIntegrationTest.java:
##########
@@ -620,6 +699,17 @@ private void deleteAndVerifyGroupConfigValue(Admin client,
verifyGroupConfig(client, groupName, defaultConfigs);
}
+ private void deleteAndVerifyClientMetricsConfigValue(Admin client,
+ String
clientMetricsName,
+ Map<String, String>
defaultConfigs) throws Exception {
Review Comment:
That would imply that the broker config `group.consumer.session.timeout.ms`
provided the default. KIP-848 does describe such a config, but does not
explicitly specify that the default should be taken from the broker config. I
think that probably it should and this is a symptom of that problem.
As an aside, we are doing exactly this in
https://github.com/apache/kafka/pull/17070 which is creating a group config
with a broker default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
