lianetm commented on code in PR #17109:
URL: https://github.com/apache/kafka/pull/17109#discussion_r1747405683
##########
clients/src/test/java/org/apache/kafka/clients/consumer/internals/CommitRequestManagerTest.java:
##########
@@ -900,6 +901,37 @@ public void
testOffsetCommitAsyncFailedWithRetriableThrowsRetriableCommitExcepti
assertFutureThrows(commitResult, RetriableCommitFailedException.class);
}
+ @ParameterizedTest
+ @MethodSource("offsetCommitExceptionSupplier")
+ public void testOffsetCommitOnFailAttemptsWhenPartitionError(final Errors
error) {
Review Comment:
nit: maybe testOffsetCommitSingleFailedAttemptWhenPartitionErrors
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
