lianetm commented on code in PR #17109:
URL: https://github.com/apache/kafka/pull/17109#discussion_r1747266859
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##########
@@ -1077,6 +1083,10 @@ private void onSuccess(final long currentTimeMs,
}
}
+ if (hasError) {
+ onFailedAttempt(currentTimeMs);
Review Comment:
don't we have here the same gap, that an early return would make that we
don't get to call onFailedAttempt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
