rich-c-shop commented on PR #17099:
URL: https://github.com/apache/kafka/pull/17099#issuecomment-2333956366

   > Could you implement two different interceptor classes in 
ProducerInterceptorsTest, one with the new signature of onAcknowledgement and 
one with the old, and then run the same parameterized tests to show they are 
equivalent in behaviour?
   
   sure. I added 2nd interceptor at 5c1c8430a4. I didn't use parameterized 
tests because the test already include two interceptors, I just change later 
one to new signature


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to