mjsax commented on code in PR #17099:
URL: https://github.com/apache/kafka/pull/17099#discussion_r1745857998
##########
clients/src/test/java/org/apache/kafka/clients/producer/KafkaProducerTest.java:
##########
@@ -2397,7 +2399,12 @@ public ProducerRecord<byte[], byte[]>
onSend(ProducerRecord<byte[], byte[]> reco
}
@Override
- public void onAcknowledgement(RecordMetadata metadata, Exception
exception) {
+ public void onAcknowledgement(RecordMetadata metadata, Exception
exception, Headers headers) {
+ if (!(headers instanceof RecordHeaders)) {
Review Comment:
For what cases do we expect this to be "false"? -- given that it is test
code, I am wondering if we need it, or if it could (in the worst case) even
mask a potential bug?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
