mumrah commented on code in PR #17066:
URL: https://github.com/apache/kafka/pull/17066#discussion_r1744156948
##########
.github/workflows/build.yml:
##########
@@ -94,18 +99,22 @@ jobs:
with:
java-version: ${{ matrix.java }}
gradle-cache-read-only: ${{ inputs.gradle-cache-read-only }}
+ gradle-cache-write-only: ${{ inputs.gradle-cache-write-only }}
develocity-access-key: ${{ secrets.GE_ACCESS_TOKEN }}
- name: Test
# Gradle flags
# --build-cache: Let Gradle restore the build cache
# --scan: Attempt to publish build scans in PRs. This will
only work on PRs from apache/kafka, not public forks.
# --continue: Keep running even if a test fails
+ # -PcommitId Prevent the Git SHA being written into the jar files
(which breaks caching)
timeout-minutes: 180 # 3 hours
+ continue-on-error: true
run: |
./gradlew --build-cache --scan --continue \
-PtestLoggingEvents=started,passed,skipped,failed \
- -PignoreFailures=true -PmaxParallelForks=2 \
+ -PmaxParallelForks=2 \
-PmaxTestRetries=1 -PmaxTestRetryFailures=10 \
+ -PcommitId=xxxxxxxxxxxxxxxx \
Review Comment:
No, this is needed for the CI to avoid breaking the cache for the `:jar` and
other downstream tasks. Otherwise, we could never cache things like
kafka-clients.jar because its contents would change on every commit, regardless
of changes to the client source files.
We really only need this kafka-version.properties file to include an actual
Git SHA for release artifacts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
