mumrah commented on code in PR #17066:
URL: https://github.com/apache/kafka/pull/17066#discussion_r1743859331
##########
.github/workflows/build.yml:
##########
@@ -94,18 +99,22 @@ jobs:
with:
java-version: ${{ matrix.java }}
gradle-cache-read-only: ${{ inputs.gradle-cache-read-only }}
+ gradle-cache-write-only: ${{ inputs.gradle-cache-write-only }}
develocity-access-key: ${{ secrets.GE_ACCESS_TOKEN }}
- name: Test
# Gradle flags
# --build-cache: Let Gradle restore the build cache
# --scan: Attempt to publish build scans in PRs. This will
only work on PRs from apache/kafka, not public forks.
# --continue: Keep running even if a test fails
+ # -PcommitId Prevent the Git SHA being written into the jar files
(which breaks caching)
timeout-minutes: 180 # 3 hours
+ continue-on-error: true
run: |
./gradlew --build-cache --scan --continue \
-PtestLoggingEvents=started,passed,skipped,failed \
- -PignoreFailures=true -PmaxParallelForks=2 \
Review Comment:
`-PignoreFailures=true` causes Gradle to consider the build successful, even
if a test task fails. This means that failing tests would be cached, which we
don't want.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
