kirktrue commented on code in PR #17035:
URL: https://github.com/apache/kafka/pull/17035#discussion_r1742664983
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##########
@@ -683,10 +683,6 @@ public ConsumerRecords<K, V> poll(final Duration timeout) {
}
do {
-
- // Make sure to let the background thread know that we are
still polling.
- applicationEventHandler.add(new
PollEvent(timer.currentTimeMs()));
-
// We must not allow wake-ups between polling for fetches and
returning the records.
// If the polled fetches are not empty the consumed position
has already been updated in the polling
// of the fetches. A wakeup between returned fetches and
returning records would lead to never
Review Comment:
That's a great question, @StanleyWu8787! I will admit I don't really
understand that aspect of the code, which is why I haven't answered your
question more satisfactorily yet. I will take a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
