AndrewJSchofield commented on code in PR #17035:
URL: https://github.com/apache/kafka/pull/17035#discussion_r1739422737
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/ApplicationEventProcessor.java:
##########
@@ -159,6 +159,9 @@ private void process(final PollEvent event) {
} else {
requestManagers.shareHeartbeatRequestManager.ifPresent(hrm ->
hrm.resetPollTimer(event.pollTimeMs()));
}
+
+ CompletableFuture<Void> future =
requestManagers.fetchRequestManager.requestFetch();
Review Comment:
Hijacking the poll event like this is not quite going to work for the share
consumer. In the share consumer, we use the PollEvent to signal that polling is
occurring, and we have a separate ShareFetch event that asks the
ShareConsumeRequestManager to fetch more records. There is no
FetchRequestManager in a share consumer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
