rreddy-22 commented on code in PR #16973:
URL: https://github.com/apache/kafka/pull/16973#discussion_r1735265785
##########
core/src/test/scala/unit/kafka/tools/StorageToolTest.scala:
##########
@@ -433,5 +433,91 @@ Found problem:
contains("Formatting dynamic metadata voter directory
%s".format(availableDirs.head)),
"Failed to find content in output: " + stream.toString())
}
-}
+ private def runVersionMappingCommand(
+ stream: ByteArrayOutputStream,
+ properties: Properties,
+ releaseVersion: String
+ ): Int = {
+ val tempDir = TestUtils.tempDir()
+ try {
+ // Write the properties to a temporary file
+ val configPathString = new File(tempDir.getAbsolutePath,
"version-mapping.props").toString
Review Comment:
Ah yes my bad I didn't realize I added the config arg method for the version
mapping parser when I was making the code modular, thanks for the catch!
Updated the tests as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
