jolshan commented on code in PR #16973:
URL: https://github.com/apache/kafka/pull/16973#discussion_r1733173418
##########
tools/src/main/java/org/apache/kafka/tools/FeatureCommand.java:
##########
@@ -282,6 +298,32 @@ static void handleDisable(Namespace namespace, Admin
adminClient) throws TerseEx
update("disable", adminClient, updates,
namespace.getBoolean("dry_run"));
}
+ static void handleVersionMapping(Namespace namespace) throws
TerseException {
+ // Get the release version from the command-line arguments or default
to the latest stable version
+ String releaseVersion =
Optional.ofNullable(namespace.getString("release_version"))
+ .orElseGet(() -> {
+ String latestVersion =
MetadataVersion.latestProduction().version();
+ System.out.println("No release version provided. Defaulting to
the latest stable version: " + latestVersion);
Review Comment:
I guess I'm just wondering if this line is needed. I think it could make it
harder to parse the output if it is expecting a certain format.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
