brandboat commented on code in PR #16824:
URL: https://github.com/apache/kafka/pull/16824#discussion_r1732856379
##########
core/src/test/java/kafka/testkit/TestKitNodes.java:
##########
@@ -53,6 +57,8 @@ public static class Builder {
private Map<Integer, Map<String, String>> perServerProperties =
Collections.emptyMap();
private BootstrapMetadata bootstrapMetadata = BootstrapMetadata.
fromVersion(MetadataVersion.latestTesting(), "testkit");
+ private ListenerName listenerName = BROKER_LISTENER_NAME;
+ private SecurityProtocol securityProtocol = BROKER_SECURITY_PROTOCOL;
Review Comment:
~~Not only ClusterTest use TestKitNode, there are many places like
BrokerMetadataPublisherTest, KRaftClusterTest, ZkMigrationIntegrationTest
directly TestKitNodes. That means we still need this default value.~~
(Update): I'll try to remove those default values, but that might need to
change some test (perhaps add listener config or something else). Anyway, worth
a try.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
