brandboat commented on code in PR #16824:
URL: https://github.com/apache/kafka/pull/16824#discussion_r1731353531
##########
core/src/test/java/kafka/test/ClusterTestExtensionsTest.java:
##########
@@ -251,8 +251,7 @@ public void testClusterAliveBrokers(ClusterInstance
clusterInstance) throws Exce
Assertions.assertTrue(clusterInstance.brokers().containsKey(0));
}
-
- @ClusterTest(types = {Type.ZK, Type.CO_KRAFT, Type.KRAFT}, brokers = 4)
+ @ClusterTest(types = {Type.ZK, Type.CO_KRAFT, Type.KRAFT}, brokers = 4,
listener = "TEST_LISTENER")
Review Comment:
In the beginning I just want to show an example about how to set listener in
annotation. But that's not needed, I will remote in the next commit. Thanks.
##########
core/src/test/java/kafka/test/ClusterTestExtensionsTest.java:
##########
@@ -251,8 +251,7 @@ public void testClusterAliveBrokers(ClusterInstance
clusterInstance) throws Exce
Assertions.assertTrue(clusterInstance.brokers().containsKey(0));
}
-
- @ClusterTest(types = {Type.ZK, Type.CO_KRAFT, Type.KRAFT}, brokers = 4)
+ @ClusterTest(types = {Type.ZK, Type.CO_KRAFT, Type.KRAFT}, brokers = 4,
listener = "TEST_LISTENER")
Review Comment:
In the beginning I just want to show an example about how to set listener in
annotation. But that's not needed, I will remove this in the next commit.
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
