dajac commented on code in PR #16826:
URL: https://github.com/apache/kafka/pull/16826#discussion_r1721887960
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java:
##########
@@ -1460,10 +1460,14 @@ public void handle(OffsetFetchResponse response,
RequestFuture<Map<TopicPartitio
if (responseError == Errors.COORDINATOR_LOAD_IN_PROGRESS) {
// just retry
future.raise(responseError);
- } else if (responseError == Errors.NOT_COORDINATOR) {
+ } else if (responseError == Errors.COORDINATOR_NOT_AVAILABLE ||
+ responseError == Errors.NOT_COORDINATOR) {
// re-discover the coordinator and retry
markCoordinatorUnknown(responseError);
future.raise(responseError);
+ } else if (responseError.exception() instanceof
RetriableException) {
Review Comment:
Would it make sense to move this branch to after `} else if (responseError
== Errors.GROUP_AUTHORIZATION_FAILED) {` to ensure that we handle all the
special cases before we handle the general ones?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
